New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only open generated files once. #1330

Merged
merged 1 commit into from Aug 6, 2017

Conversation

Projects
None yet
1 participant
@raphael
Copy link
Member

raphael commented Aug 4, 2017

This is required for performance reasons especially on Windows. Unfortunately
this also means that files must now be explicitly closed.

Only open generated files once.
This is required for performance reasons especially on Windows. Unfortunately
this also means that files must now be explicitly closed.

@raphael raphael force-pushed the v1.open_generated_file_once branch from 3298056 to f10c86d Aug 6, 2017

@raphael raphael merged commit fb33e78 into v1 Aug 6, 2017

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@raphael raphael deleted the v1.open_generated_file_once branch Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment