New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly test for required attributes when unmarshaling #1521

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
1 participant
@raphael
Copy link
Member

raphael commented Feb 3, 2018

The code checking for presence of validation to know whether to generate a call to the payload 'Validate' method wasn't taking into account the case where the type only had required attribute validations.

Fix #1507

Properly test for required attributes when unmarshaling
The code checking for presence of validation to know whether to generate a call to the payload 'Validate' method wasn't taking into account the case where the type only had required attribute validations.

Fix #1507

@raphael raphael merged commit 108eb15 into v1 Feb 3, 2018

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@raphael raphael deleted the v1.fix_unmarshal_validation_required branch Feb 3, 2018

@jiekang jiekang referenced this pull request Jul 13, 2018

Closed

Add 1.x.y release tag #1807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment