Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1: Prevent pointer to '*interface{}' in user types #1611

Merged
merged 2 commits into from Mar 19, 2018

Conversation

@xoob
Copy link

@xoob xoob commented Mar 18, 2018

A previous patch in [#1591][1] addressed an issue where optional fields
of kind "Any" would result in a pointer to interface. We fix an
additional occurence of this problem in private user types, which follow
slightly different logic than the public media types previously fixed
and add a test case for private defs.

[1]: https://github.com/goadesign/goa/pull/1591

This is a backport of #1610 to the "v1" stable branch.

xoob added 2 commits Mar 18, 2018
A previous patch in [#1591][1] addressed an issue where optional fields
of kind "Any" would result in a pointer to interface. We fix an
additional occurence of this problem in private user types, which follow
slightly different logic than the public media types previously fixed
and add a test case for private defs.

[1]: #1591
@raphael raphael merged commit 33ac328 into goadesign:v1 Mar 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jiekang jiekang mentioned this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants