Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to v1: Add support for readonly attributes (#1762) #1776

Merged

Conversation

@dikhan
Copy link

@dikhan dikhan commented Jun 24, 2018

  • Add support for readonly attributes

  • run go fmt

  • use metadata to set readonly flag instead

Conflicts:

design/apidsl/attribute.go

* Add support for readonly attributes

* run go fmt

* use metadata to set readonly flag instead

# Conflicts:
#	design/apidsl/attribute.go
@raphael
Copy link
Member

@raphael raphael commented Jun 25, 2018

Looks great, thank you!

@raphael raphael merged commit 63cbef4 into goadesign:v1 Jun 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jiekang jiekang mentioned this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants