bugfix type error in multipart-form payload #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael
reviewed
Sep 23, 2018
goagen/gen_app/writers.go
Outdated
| case design.NumberKind: | ||
| return "ParseFloat" | ||
| } | ||
| panic("undefined strconv function") |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
goagen/gen_app/writers.go
Outdated
| @@ -451,6 +456,34 @@ func arrayAttribute(a *design.AttributeDefinition) *design.AttributeDefinition { | |||
| return a.Type.(*design.Array).ElemType | |||
| } | |||
|
|
|||
| func valueTypeOf(pr string, att *design.AttributeDefinition) string { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aya-eiya
commented
Sep 25, 2018
| return varName + ", (error)(nil)" | ||
| case design.ArrayKind: | ||
| case design.HashKind: | ||
| return valueTypeOf("", att) + "{}, (error)(nil)" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| return varName + ", (error)(nil)" | ||
| case design.ArrayKind: | ||
| case design.HashKind: | ||
| return valueTypeOf("", att) + "{}, (error)(nil)" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| case design.HashKind: | ||
| return valueTypeOf("", att) + "{}, (error)(nil)" | ||
| } | ||
| return "(" + valueTypeOf("", att) + ")(nil), (error)(nil)" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thank you, definitely an improvement compared to the original code! |
|
One last request please, could you port this fix to master as well? (cherry-pick the merge commit). |
aya-eiya
added a commit
to aya-eiya/goa
that referenced
this pull request
Sep 28, 2018
* bugfix type error in multipart-form payload * bugfix Array attribute error in multipartform * fix wrong comment line and add comment to new function * fix fromString func to do not cause panic and support some other types for array element
|
@raphael |
raphael
pushed a commit
that referenced
this pull request
Sep 28, 2018
* bugfix type error in multipart-form payload * bugfix Array attribute error in multipartform * fix wrong comment line and add comment to new function * fix fromString func to do not cause panic and support some other types for array element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for #1862
type errors occur when set MultipartForm flag