New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build.Default.GOPATH instead of env GOPATH #1930

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@tchssk
Copy link
Member

tchssk commented Dec 10, 2018

Go v1.8+ set a default GOPATH if the GOPATH env variable is not set. This patch makes it possible to use goagen with a default GOPATH.

I found this issue during trying to improve goa to support Go modules (for #1914). I'm plannning to open another pull request for that.

@tchssk

This comment has been minimized.

Copy link
Member Author

tchssk commented Dec 10, 2018

Travis says

/home/travis/gopath/src/github.com/goadesign/goa/metrics.go
/home/travis/gopath/src/github.com/goadesign/goa/metrics_test.go
^ - Repo contains improperly formatted go files

but the files look OK to me...

@tchssk tchssk force-pushed the tchssk:build-default-gopath branch from 74eef5d to b08c824 Dec 11, 2018

@tchssk

This comment has been minimized.

Copy link
Member Author

tchssk commented Dec 11, 2018

It was caused by new behavior of goimports. It's resolved and ready to merge.

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Dec 14, 2018

This is great! thank you.

@raphael raphael merged commit 6b56306 into goadesign:master Dec 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tchssk tchssk deleted the tchssk:build-default-gopath branch Dec 16, 2018

raphael added a commit that referenced this pull request Jan 29, 2019

Use build.Default.GOPATH instead of env GOPATH (#1930)
* Use build.Default.GOPATH instead of env GOPATH

* Specify package name for some packages

raphael added a commit that referenced this pull request Jan 29, 2019

Use build.Default.GOPATH instead of env GOPATH (#1930) (#1977)
* Use build.Default.GOPATH instead of env GOPATH

* Specify package name for some packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment