New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.11 Modules by goagen #1933

Merged
merged 2 commits into from Dec 16, 2018

Conversation

Projects
None yet
2 participants
@tchssk
Copy link
Member

tchssk commented Dec 16, 2018

@tchssk tchssk force-pushed the tchssk:go111module branch from 6cfca9c to 922a15c Dec 16, 2018

@raphael
Copy link
Member

raphael left a comment

This is great, thank you! Just one tiny typo.

As a note for goa v2 I'm thinking we need to create a new repo so that import goa.design/goa can keep working with Go modules (otherwise the go tool checks out the v1 branch and we'd have to create a v2 folder and move the v2 branch content to it which isn't great).

@@ -368,6 +406,107 @@ func PackageName(path string) (string, error) {
return pkgNames[0], nil
}

// Copeied from cmd/go/internal/modload/init.go.

This comment has been minimized.

@raphael

This comment has been minimized.

@tchssk

tchssk Dec 16, 2018

Author Member

L425 had a same typo. I fixed both.

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Dec 16, 2018

Thanks!

@raphael raphael merged commit 14b7b99 into goadesign:master Dec 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tchssk tchssk deleted the tchssk:go111module branch Dec 17, 2018

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Jan 28, 2019

I just realized that the tests don't pass on Windows - see appveyor. @tchssk do you think you could take a look? thank you!

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Jan 28, 2019

Also this should probably be ported to v1.

raphael added a commit that referenced this pull request Jan 28, 2019

Support Go 1.11 Modules by goagen (#1933)
* Support Go 1.11 Modules by goagen

* Fix typo
@raphael

This comment has been minimized.

Copy link
Member

raphael commented Jan 28, 2019

Fixed in #1974

raphael added a commit that referenced this pull request Jan 28, 2019

Support Go 1.11 Modules by goagen (#1933)
* Support Go 1.11 Modules by goagen

* Fix typo
@tchssk

This comment has been minimized.

Copy link
Member Author

tchssk commented Jan 28, 2019

Thank you for fixing the tests.

  • Has #1930 been applied onto v1? It should be ported too.
  • The new version contains some new features. Is it not v1.5.0 but 1.4.1?
@raphael

This comment has been minimized.

Copy link
Member

raphael commented Jan 28, 2019

hmm yes #1930 should be ported, good catch!
The only new feature really is support for Go modules I think? it didn't seem like that justified a minor version upgrade.

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Jan 29, 2019

I have ported #1930 to v1 and retagged v1.4.1, thank you!

@tchssk

This comment has been minimized.

Copy link
Member Author

tchssk commented Jan 29, 2019

OK. I agree to v1.4.1.

@tchssk

This comment has been minimized.

Copy link
Member Author

tchssk commented Jan 29, 2019

BTW you should announce v1.4.1 on Twitter. @raphael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment