Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.11 Modules by goagen #1933

Merged
merged 2 commits into from Dec 16, 2018
Merged

Support Go 1.11 Modules by goagen #1933

merged 2 commits into from Dec 16, 2018

Conversation

@tchssk
Copy link
Member

@tchssk tchssk commented Dec 16, 2018

#1914

Copy link
Member

@raphael raphael left a comment

This is great, thank you! Just one tiny typo.

As a note for goa v2 I'm thinking we need to create a new repo so that import goa.design/goa can keep working with Go modules (otherwise the go tool checks out the v1 branch and we'd have to create a v2 folder and move the v2 branch content to it which isn't great).

Loading

@@ -368,6 +406,107 @@ func PackageName(path string) (string, error) {
return pkgNames[0], nil
}

// Copeied from cmd/go/internal/modload/init.go.
Copy link
Member

@raphael raphael Dec 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Loading

Copy link
Member Author

@tchssk tchssk Dec 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L425 had a same typo. I fixed both.

Loading

@raphael
Copy link
Member

@raphael raphael commented Dec 16, 2018

Thanks!

Loading

@raphael raphael merged commit 14b7b99 into goadesign:master Dec 16, 2018
1 check passed
Loading
@tchssk tchssk deleted the go111module branch Dec 17, 2018
@raphael
Copy link
Member

@raphael raphael commented Jan 28, 2019

I just realized that the tests don't pass on Windows - see appveyor. @tchssk do you think you could take a look? thank you!

Loading

@raphael
Copy link
Member

@raphael raphael commented Jan 28, 2019

Also this should probably be ported to v1.

Loading

raphael added a commit that referenced this issue Jan 28, 2019
* Support Go 1.11 Modules by goagen

* Fix typo
@raphael
Copy link
Member

@raphael raphael commented Jan 28, 2019

Fixed in #1974

Loading

raphael added a commit that referenced this issue Jan 28, 2019
* Support Go 1.11 Modules by goagen

* Fix typo
@tchssk
Copy link
Member Author

@tchssk tchssk commented Jan 28, 2019

Thank you for fixing the tests.

  • Has #1930 been applied onto v1? It should be ported too.
  • The new version contains some new features. Is it not v1.5.0 but 1.4.1?

Loading

@raphael
Copy link
Member

@raphael raphael commented Jan 28, 2019

hmm yes #1930 should be ported, good catch!
The only new feature really is support for Go modules I think? it didn't seem like that justified a minor version upgrade.

Loading

@raphael
Copy link
Member

@raphael raphael commented Jan 29, 2019

I have ported #1930 to v1 and retagged v1.4.1, thank you!

Loading

@tchssk
Copy link
Member Author

@tchssk tchssk commented Jan 29, 2019

OK. I agree to v1.4.1.

Loading

@tchssk
Copy link
Member Author

@tchssk tchssk commented Jan 29, 2019

BTW you should announce v1.4.1 on Twitter. @raphael

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants