Allow security scopes on BasicAuth and APIKey authentication #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael
reviewed
May 24, 2019
|
Thank you! I made the changes. |
|
Looks great! thank you. Do you think you could backport these changes to v2 as well? Simply cherry-pick the merge commit into a branch created off of v2. Thank you! |
cubic3d
added a commit
to cubic3d/goa
that referenced
this pull request
Jun 21, 2019
…gn#2120) * Added scopes support in BasicAuth and APIKeyAuth for custom usage * Fixed consistency between endpoint and auth schema generated descriptions * Fixed comments on scheme Validate * Fixed font weight on endpoint description * Changed Scope docs, added to "must appear" list * Refactored scope description generation
raphael
pushed a commit
that referenced
this pull request
Jul 14, 2019
…2162) * Added scopes support in BasicAuth and APIKeyAuth for custom usage * Fixed consistency between endpoint and auth schema generated descriptions * Fixed comments on scheme Validate * Fixed font weight on endpoint description * Changed Scope docs, added to "must appear" list * Refactored scope description generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2105 and allows to define
ScopeonBasicAuthandAPIKeyAuthdefinitions.Description on endpoint now contains the
Securityname to distinguish between the methods. Additionally consistent formatting is applied to descriptions containing security scopes.