Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NameScope Unique method #2152

Merged
merged 3 commits into from Jul 1, 2019

Conversation

@ikawaha
Copy link
Contributor

commented Jun 15, 2019

see #2151

ikawaha added 3 commits Jun 14, 2019
@nitinmohan87
Copy link
Contributor

left a comment

Looks good to me. Will let @raphael make the final say.

@raphael

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Looks great, thank you for the fix!

@raphael raphael merged commit 3847677 into goadesign:v3 Jul 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raphael

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

@ikawaha do you think you could backport this fix to v2? (simply cherry-pick the merge commit into a branch created off of v2). Thank you!

ikawaha added a commit to ikawaha/goa that referenced this pull request Jul 1, 2019
Fix NameScope Unique method (goadesign#2152)
* Fix Unique

* Update

* Cosme
raphael added a commit that referenced this pull request Jul 1, 2019
Fix NameScope Unique method (#2152) (#2171)
* Fix Unique

* Update

* Cosme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.