Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NameScope Unique method #2152

Merged
merged 3 commits into from Jul 1, 2019
Merged

Fix NameScope Unique method #2152

merged 3 commits into from Jul 1, 2019

Conversation

@ikawaha
Copy link
Contributor

@ikawaha ikawaha commented Jun 15, 2019

see #2151

Copy link
Contributor

@nitinmohan87 nitinmohan87 left a comment

Looks good to me. Will let @raphael make the final say.

Loading

@raphael
Copy link
Member

@raphael raphael commented Jul 1, 2019

Looks great, thank you for the fix!

Loading

@raphael raphael merged commit 3847677 into goadesign:v3 Jul 1, 2019
1 check passed
Loading
@raphael
Copy link
Member

@raphael raphael commented Jul 1, 2019

@ikawaha do you think you could backport this fix to v2? (simply cherry-pick the merge commit into a branch created off of v2). Thank you!

Loading

ikawaha added a commit to ikawaha/goa that referenced this issue Jul 1, 2019
* Fix Unique

* Update

* Cosme
raphael added a commit that referenced this issue Jul 1, 2019
* Fix Unique

* Update

* Cosme
@ikawaha ikawaha deleted the fix/scope branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants