Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2157 - Add support for text plain content type #2165

Merged
merged 4 commits into from Jul 1, 2019
Merged

Issue 2157 - Add support for text plain content type #2165

merged 4 commits into from Jul 1, 2019

Conversation

@ilmaruk
Copy link
Contributor

@ilmaruk ilmaruk commented Jun 28, 2019

Since the implementations of Encode and Decode for http.textHtml* and http.textPlain* would have been the very same, I opted for introducing a single http.textEncoder and http.textDecoder.

It should be easy enough to split them in the future, if needed.

I also took the chance of adding some tests around the code I modified.

@raphael
Copy link
Member

@raphael raphael commented Jul 1, 2019

Thank you for the great PR, love the additional tests! Do you think you could backport this to v2 as well? Simply cherry-pick the merge commit into a branch created off of v2, thank you!.

Loading

@raphael raphael merged commit 2acf09c into goadesign:v3 Jul 1, 2019
1 check passed
Loading
@ilmaruk
Copy link
Contributor Author

@ilmaruk ilmaruk commented Jul 2, 2019

Loading

raphael added a commit that referenced this issue Jul 3, 2019
* Added textPlainEncoder and textPlainDecoder

* Merged textPlain and textHTML encoder and decoder into single one.

* Added TestResponseDecoder.

* Added TestResponseEncoder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants