Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move xray test helpers into separate package #2190

Merged
merged 4 commits into from Jul 10, 2019

Conversation

@tmaflexera
Copy link
Contributor

commented Jul 9, 2019

Fixes #2160 ("testing" imported by production code)

@raphael

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Thank you! Would you mind back-porting this to v2 as well? (just cherry-pick the merge commit into a branch created off of the v2 branch).

@raphael raphael merged commit eeb68ca into goadesign:v3 Jul 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
tmaflexera added a commit to tmaflexera/goa that referenced this pull request Jul 10, 2019
Move xray test helpers into separate package (goadesign#2190)
* Rename testing.go to testing_test.go so that
"testing" is not imported in release code

* Move testing.go into its own xraytest pkg

* Change tests to refer to separate xraytest pkg

* Added package comment for staticcheck

(cherry picked from commit eeb68ca)
raphael added a commit that referenced this pull request Jul 14, 2019
Move xray test helpers into separate package (#2190) (#2192)
* Rename testing.go to testing_test.go so that
"testing" is not imported in release code

* Move testing.go into its own xraytest pkg

* Change tests to refer to separate xraytest pkg

* Added package comment for staticcheck

(cherry picked from commit eeb68ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.