Move xray test helpers into separate package #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"testing" is not imported in release code
|
Thank you! Would you mind back-porting this to v2 as well? (just cherry-pick the merge commit into a branch created off of the v2 branch). |
tmcladam
added a commit
to tmcladam/goa
that referenced
this pull request
Jul 10, 2019
* Rename testing.go to testing_test.go so that "testing" is not imported in release code * Move testing.go into its own xraytest pkg * Change tests to refer to separate xraytest pkg * Added package comment for staticcheck (cherry picked from commit eeb68ca)
raphael
pushed a commit
that referenced
this pull request
Jul 14, 2019
* Rename testing.go to testing_test.go so that "testing" is not imported in release code * Move testing.go into its own xraytest pkg * Change tests to refer to separate xraytest pkg * Added package comment for staticcheck (cherry picked from commit eeb68ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2160 ("testing" imported by production code)