Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move xray test helpers into separate package #2190

Merged
merged 4 commits into from Jul 10, 2019
Merged

Move xray test helpers into separate package #2190

merged 4 commits into from Jul 10, 2019

Conversation

@tmcladam
Copy link
Contributor

@tmcladam tmcladam commented Jul 9, 2019

Fixes #2160 ("testing" imported by production code)

@raphael
Copy link
Member

@raphael raphael commented Jul 10, 2019

Thank you! Would you mind back-porting this to v2 as well? (just cherry-pick the merge commit into a branch created off of the v2 branch).

Loading

@raphael raphael merged commit eeb68ca into goadesign:v3 Jul 10, 2019
1 check passed
Loading
tmcladam pushed a commit to tmcladam/goa that referenced this issue Jul 10, 2019
* Rename testing.go to testing_test.go so that
"testing" is not imported in release code

* Move testing.go into its own xraytest pkg

* Change tests to refer to separate xraytest pkg

* Added package comment for staticcheck

(cherry picked from commit eeb68ca)
raphael added a commit that referenced this issue Jul 14, 2019
* Rename testing.go to testing_test.go so that
"testing" is not imported in release code

* Move testing.go into its own xraytest pkg

* Change tests to refer to separate xraytest pkg

* Added package comment for staticcheck

(cherry picked from commit eeb68ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants