Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: grpc xray client stream wrapper: record success on io.EOF #2229

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@tmaflexera
Copy link
Contributor

commented Aug 7, 2019

No description provided.

@tmaflexera

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Fixes #2230

@nitinmohan87
Copy link
Contributor

left a comment

Looks good. Thanks!

@nitinmohan87 nitinmohan87 merged commit 206b6d0 into goadesign:v3 Aug 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nitinmohan87

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@tmaflexera Could you also port this to v2?

tmaflexera added a commit to tmaflexera/goa that referenced this pull request Aug 8, 2019

@tmaflexera tmaflexera deleted the tmaflexera:grpc_xray_EOF_ok branch Aug 8, 2019

@tmaflexera

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Sent PR #2231 for v2

raphael added a commit that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.