Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cyclic definition for CollectionOf #2517

Merged
merged 3 commits into from Mar 25, 2020
Merged

Conversation

nitinmohan87
Copy link
Contributor

@nitinmohan87 nitinmohan87 commented Mar 24, 2020

Fixes #2514

dsl/result_type.go Show resolved Hide resolved
@raphael
Copy link
Member

@raphael raphael commented Mar 25, 2020

Looks great, thank you! Can you please port this back to v2 as well?

@raphael raphael merged commit 96f4f91 into v3 Mar 25, 2020
2 checks passed
@raphael raphael deleted the fix_recursive_collection_of branch Mar 25, 2020
nitinmohan87 added a commit that referenced this issue May 2, 2020
* Fix cyclic definition for CollectionOf

* Encapsulate result type name derivation logic

* Address review comments
raphael pushed a commit that referenced this issue May 2, 2020
* Fix cyclic definition for CollectionOf

* Encapsulate result type name derivation logic

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants