Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bearer in client request encode #2563

Merged
merged 2 commits into from May 21, 2020
Merged

Set bearer in client request encode #2563

merged 2 commits into from May 21, 2020

Conversation

nitinmohan87
Copy link
Contributor

@nitinmohan87 nitinmohan87 commented May 21, 2020

HTTP client didn't encode Authorization header with Bearer scheme for JWT and OAuth2 by default. This is because, we computed scheme data from the Method requirements instead of endpoint requirements. We modify the endpoint scheme in the HTTP endpoint finalize to include "Authorization" scheme name.

This PR fixes how we compute requirement data for HTTP endpoints.

@raphael
Copy link
Member

@raphael raphael commented May 21, 2020

Thank you! Can you please back-port the fix to v2? thanks!

@raphael raphael merged commit faf83e7 into v3 May 21, 2020
4 checks passed
@raphael raphael deleted the set_bearer_client_encode branch May 21, 2020
nitinmohan87 added a commit that referenced this issue May 21, 2020
* Set bearer in client request encode

* Fix test
raphael pushed a commit that referenced this issue May 21, 2020
* Set bearer in client request encode

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants