Set bearer in client request encode #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Can you please back-port the fix to v2? thanks! |
nitinmohan87
added a commit
that referenced
this pull request
May 21, 2020
* Set bearer in client request encode * Fix test
raphael
pushed a commit
that referenced
this pull request
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP client didn't encode Authorization header with Bearer scheme for JWT and OAuth2 by default. This is because, we computed scheme data from the Method requirements instead of endpoint requirements. We modify the endpoint scheme in the HTTP endpoint finalize to include "Authorization" scheme name.
This PR fixes how we compute requirement data for HTTP endpoints.