Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixed invalid context value passing to
context.WithTimeout
for graceful-shutdown.Current generated example of graceful-shutdown is calling
context.WithTimeout
with already closed context, because of that server shutdown immediately. I don't think it is intentional behavior, so fixed with passingcontext.Background
tocontext.WithTimeout
explanation
changes to examples can be reviewed in: goadesign/examples#71