Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIGTERM handling #2604

Merged
merged 1 commit into from Jul 6, 2020
Merged

Add SIGTERM handling #2604

merged 1 commit into from Jul 6, 2020

Conversation

shunyy
Copy link
Contributor

@shunyy shunyy commented Jul 5, 2020

Current generated(goa example) code states that it supports SIGINT and SIGTERM for graceful shutdown.

// Setup interrupt handler. This optional step configures the process so
// that SIGINT and SIGTERM signals cause the services to stop gracefully.

But it actually support only SIGINT, not SIGTERM.
I think it is better to support SIGTERM for better support of kubernetes or ECS (and so on...) container lifecycle.

@raphael
Copy link
Member

@raphael raphael commented Jul 6, 2020

Makes sense, thank you. Please back-port to v2 as well, thanks again!

@raphael raphael merged commit b4320c4 into goadesign:v3 Jul 6, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants