goa.adapter#logit(): remove unneeded check which would make an unsafe concurrent modification #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - logit() doesn't need to modify a.keyvals because it was already fixed up in New()
ghost
changed the title
ghost
changed the title
|
Thank you! could I convince you to add a test that would have failed prior to this fix? |
| @@ -76,9 +76,6 @@ func (a *adapter) logit(msg string, keyvals []interface{}, iserror bool) { | |||
| keyvals = append(keyvals, ErrMissingLogValue) | |||
| } | |||
| m := (len(a.keyvals) + 1) / 2 | |||
| if len(a.keyvals)%2 != 0 { | |||
| a.keyvals = append(a.keyvals, ErrMissingLogValue) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
oh I misread the fix... looks great, thanks! |
51 tasks
ikawaha
pushed a commit
to ikawaha/goa
that referenced
this pull request
Dec 13, 2016
…tion (goadesign#736) - logit() doesn't need to modify a.keyvals because it was already fixed up in New()
5 tasks
raphael
pushed a commit
that referenced
this pull request
Dec 14, 2016
* Added the ability to dynamically add/remove keys from the jwt security middleware after creation. (#818) * Refactor JWT key resolver (#832) To introduce new "simple" resolver. * Add an interface instead of using testing.T (#733) * removed unneeded check which would make an unsafe concurrent modification (#736) - logit() doesn't need to modify a.keyvals because it was already fixed up in New() * Modify metrics so that names are normalized to legal chars (#771) * Add normalizeKeys() function for normalizing metric key names * Properly synchronize updates to metrics object * Fix setting a default value to datetime * Add tests for a default value of datetime * address issue #738 by creating a title for the test file * Fix a finalize test * Revert "Refactor JWT key resolver (#832)" This reverts commit f6ecb66. * Revert "Added the ability to dynamically add/remove keys from the jwt security middleware after creation. (#818)" This reverts commit 4c7fc9d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a.keyvalsbecause it was already fixed up in New()