Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UseTrait APIDSL function to be variadic #816

Merged
merged 3 commits into from Oct 11, 2016
Merged

Change UseTrait APIDSL function to be variadic #816

merged 3 commits into from Oct 11, 2016

Conversation

@jsimonetti
Copy link

@jsimonetti jsimonetti commented Oct 11, 2016

Signed-off-by: Jeroen Simonetti jeroen@simonetti.nl

jsimonetti added 2 commits Oct 11, 2016
Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
@jsimonetti
Copy link
Author

@jsimonetti jsimonetti commented Oct 11, 2016

If this is approved I'll work on a PR against V1

@raphael
Copy link
Member

@raphael raphael commented Oct 11, 2016

Looks great, thank you! Just one tiny thing: please update the header comment of UseTrait to document this new behavior. Other than that LGTM!

Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
@raphael
Copy link
Member

@raphael raphael commented Oct 11, 2016

Thank you!

@raphael raphael merged commit b418049 into goadesign:master Oct 11, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants