New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UseTrait APIDSL function to be variadic #816

Merged
merged 3 commits into from Oct 11, 2016

Conversation

Projects
None yet
2 participants
@jsimonetti
Copy link
Contributor

jsimonetti commented Oct 11, 2016

Signed-off-by: Jeroen Simonetti jeroen@simonetti.nl

jsimonetti added some commits Oct 11, 2016

Change UseTrait APIDSL function to be variadic
Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
Add UseTrait variadic test
Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
@jsimonetti

This comment has been minimized.

Copy link
Contributor

jsimonetti commented Oct 11, 2016

If this is approved I'll work on a PR against V1

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Oct 11, 2016

Looks great, thank you! Just one tiny thing: please update the header comment of UseTrait to document this new behavior. Other than that LGTM!

Update UseTrait documentation
Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
@raphael

This comment has been minimized.

Copy link
Member

raphael commented Oct 11, 2016

Thank you!

@raphael raphael merged commit b418049 into goadesign:master Oct 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment