Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup for 2e83b0dfdd45e1e54615606924dca565b547b08b #900

Merged
merged 2 commits into from Nov 21, 2016

Conversation

kwk
Copy link

@kwk kwk commented Nov 21, 2016

We are using the v1 branch and lately there seems to be a change about the contentType parameter. I've commented on the recent commit here.

This change removes the parameter contentType parameter from a function call under the same conditions as introduced in 2e83b0d.

Also, I've added a workaround to remove the header declared and not used error which was caused because no content type is being anymore.

We are using the v1 branch and lately there seems to be a change about the `contentType` parameter. I've commented on the recent commit [here](goadesign@2e83b0d#commitcomment-19905560). 

This change removes the parameter `contentType` parameter from a function call under the same conditions as introduced in 2e83b0d.

Also, I've added a workaround to remove the `header declared and not used error` which was caused because no content type is being anymore.
@@ -990,6 +990,7 @@ func (c *Client) {{ $funcName }}(ctx context.Context, path string{{ if .Params }
return nil, err
}
{{ if or .Headers .HasPayload }} header := req.Header
_ = header // Avoid "header declared and not used" error
{{ if .HasPayload }}{{ if .HasMultiContent }} if contentType != "*/*" {

This comment was marked as off-topic.

This comment was marked as off-topic.

@raphael
Copy link
Member

raphael commented Nov 21, 2016

Thank you! I added a comment in the commit, do you think you could make that change? and once you've made it could you also make a PR against branch v1. Thank you again, much appreciated!

@raphael
Copy link
Member

raphael commented Nov 21, 2016

Thank you!

@raphael raphael merged commit c72c2cd into goadesign:master Nov 21, 2016
kwk added a commit to kwk/goa that referenced this pull request Nov 21, 2016
* Fixup for 2e83b0d

We are using the v1 branch and lately there seems to be a change about the `contentType` parameter. I've commented on the recent commit [here](goadesign@2e83b0d#commitcomment-19905560). 

This change removes the parameter `contentType` parameter from a function call under the same conditions as introduced in 2e83b0d.

Also, I've added a workaround to remove the `header declared and not used error` which was caused because no content type is being anymore.

* Create header if .HasPayload .HasMultiContent 

See goadesign#900 (review) for change request.
@kwk kwk deleted the patch-2 branch November 21, 2016 18:03
kwk added a commit to kwk/goa that referenced this pull request Nov 21, 2016
* Fixup for 2e83b0d

We are using the v1 branch and lately there seems to be a change about the `contentType` parameter. I've commented on the recent commit [here](goadesign@2e83b0d#commitcomment-19905560). 

This change removes the parameter `contentType` parameter from a function call under the same conditions as introduced in 2e83b0d.

Also, I've added a workaround to remove the `header declared and not used error` which was caused because no content type is being anymore.

* Create header if .HasPayload .HasMultiContent 

See goadesign#900 (review) for change request.
@kwk kwk mentioned this pull request Nov 21, 2016
@kwk
Copy link
Author

kwk commented Nov 21, 2016

@raphael

[...] and once you've made it could you also make a PR against branch v1.

Here's the PR for v1: #903

raphael pushed a commit that referenced this pull request Nov 21, 2016
* Fixup for 2e83b0d

We are using the v1 branch and lately there seems to be a change about the `contentType` parameter. I've commented on the recent commit [here](2e83b0d#commitcomment-19905560). 

This change removes the parameter `contentType` parameter from a function call under the same conditions as introduced in 2e83b0d.

Also, I've added a workaround to remove the `header declared and not used error` which was caused because no content type is being anymore.

* Create header if .HasPayload .HasMultiContent 

See #900 (review) for change request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants