Pass arguments to final generator #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will allow arguments to goagen which are add after the '--' argument to be passed allong to the generator. Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
raphael
reviewed
Dec 2, 2016
| @@ -235,10 +238,10 @@ func run(pkg string, c *cobra.Command) ([]string, error) { | |||
| if err != nil { | |||
| return nil, fmt.Errorf("invalid package import path: %s", err) | |||
| } | |||
| return generate(pkgName, pkgPath, c) | |||
| return generate(pkgName, pkgPath, c, []string{}) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
raphael
reviewed
Dec 2, 2016
| return nil, nil | ||
| } | ||
| } | ||
| return nil, fmt.Errorf("no flag --custom=arg found") |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thank you, the PR looks great. Left two nitpick comments, I'll merge once you address these. |
added 2 commits
December 3, 2016 20:51
Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
|
Thank you! Do you think you could also make a PR against the v1 branch? |
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow arguments to goagen which are add after the '--' argument to be passed allong to the generator.
The generate command becomes goagen gen -d --pkg-path= -- --custom-arg=value
Fixes #934