Generating path for client is transforming all relevant types to string first. #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the failing Travis. Going for christmas party, will take care tomorrow (central europe time). :) |
raphael
reviewed
Dec 15, 2016
| @@ -334,13 +333,50 @@ func (g *Generator) generateResourceClient(pkgDir string, res *design.ResourceDe | |||
| } | |||
| } | |||
| } | |||
| initParams := func(att *design.AttributeDefinition) []*paramData { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| return fmt.Sprintf({{ printf "%q" (pathTemplate .) }}, {{ pathParamNames . }}) | ||
| */}}// {{ $funcName }} computes a request path to the {{ .Route.Parent.Name }} action of {{ .Route.Parent.Parent.Name }}. | ||
| func {{ $funcName }}({{ pathParams .Route }}) string { | ||
| var params []interface{} |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thank you for doing this! looks great. I suggested a couple of tweaks in the comments. Have fun at the party :) |
|
Thanks for the hints and patience! This time it even looks greener than the last time :). |
|
Found one more bug with the order of generated params, expect one more commit. I've realized that |
Route params need to be generated and used in Sprintf in a correct order. As the AttributeDefinition.Type is always a map, for route params we need to maintain this order by other means. In this case by manufacturing AttributeDefinition separately for each route param.
|
Thank you for the great PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a feeling that it could be done with a bit less duplicity within
initParams. Opened to any ideas (or just push a change) :).PR is fixing issue #961, which was partially fixed yesterday.