New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate "Generated By" header for client code. #980

Merged
merged 1 commit into from Dec 19, 2016

Conversation

Projects
None yet
2 participants
@brycereitano
Copy link
Contributor

brycereitano commented Dec 18, 2016

I will create another branch to put onto master after this is reviewed.

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Dec 19, 2016

Thank you!

@raphael raphael merged commit bbf2170 into goadesign:v1 Dec 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raphael

This comment has been minimized.

Copy link
Member

raphael commented Dec 19, 2016

Can you also send a PR to master? thanks!

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Dec 19, 2016

Good old Windows keeping us on our toes:

https://ci.appveyor.com/project/RaphaelSimon/goa-oqtis/build/1528

Do you think you can tweak the test so that it uses the correct path separator? (filepath.Join should do what you need). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment