Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore fields. Gorm ignore support #159

Closed
wants to merge 2 commits into from

Conversation

tpoxa
Copy link

@tpoxa tpoxa commented Aug 9, 2017

GORM supports "-" annotation for fields which might be ignored.
This merge translates this feature for Gorma

@@ -112,6 +112,12 @@ func Nullable() {
f.Nullable = true
}
}
// Ignore this field for insert/update

This comment was marked as off-topic.

This comment was marked as off-topic.

@raphael
Copy link
Member

raphael commented Aug 9, 2017

Thank you! left a comment for a tiny change, will merge once that's done.

@raphael
Copy link
Member

raphael commented Aug 9, 2017

Thank you for making the change, it looks like the build is broken because golint isn't happy though. Does make run successfully on your box? If not can you please fix the build? make completes successfully for me.

Copy link
Author

@tpoxa tpoxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me these 9 lines are working good. I use it in several projects.

@@ -112,6 +112,12 @@ func Nullable() {
f.Nullable = true
}
}
// Ignore this field for insert/update

This comment was marked as off-topic.

@raphael
Copy link
Member

raphael commented Nov 19, 2017

yes the code works but the file isn't formatted properly which is why the test fails, see https://travis-ci.org/goadesign/gorma/jobs/262609403#L307-L308
Please run "make" and fix the formatting issue and I'll merge the PR. Thank you!

@raphael
Copy link
Member

raphael commented May 24, 2018

Closing because no activity.

@raphael raphael closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants