CORS: Fix panic due to unsafe type assertion #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 13, 2022 13:51
--- FAIL: TestMountIndexHTML (0.00s)
panic: interface conversion: http.Handler is *http.fileHandler, not
http.HandlerFunc [recovered]
panic: interface conversion: http.Handler is *http.fileHandler, not
http.HandlerFunc
goroutine 20 [running]:
testing.tRunner.func1.2({0x104907a40, 0x140000ab9e0})
/opt/homebrew/Cellar/go/1.17.3/libexec/src/testing/testing.go:1209
+0x258
testing.tRunner.func1(0x140000829c0)
/opt/homebrew/Cellar/go/1.17.3/libexec/src/testing/testing.go:1212
+0x284
panic({0x104907a40, 0x140000ab9e0})
/opt/homebrew/Cellar/go/1.17.3/libexec/src/runtime/panic.go:1038
+0x21c
goa.design/plugins/v3/cors/examples/calc/gen/http/calc/server.HandleCalcOrigin({0x10496a9c0,
0x14000094e30})
/Users/_/go/src/goa.design/plugins/cors/examples/calc/gen/http/calc/server/server.go:175
+0xe8
goa.design/plugins/v3/cors/examples/calc/gen/http/calc/server.MountIndexHTML({0x104972478,
0x14000096218}, {0x10496a9c0, 0x14000094e30})
/Users/_/go/src/goa.design/plugins/cors/examples/calc/gen/http/calc/server/server.go:147
+0x30
goa.design/plugins/v3/cors/examples/calc/gen/http/calc/server.Mount({0x104972478,
0x14000096218}, 0x140000ba0a0)
/Users/_/go/src/goa.design/plugins/cors/examples/calc/gen/http/calc/server/server.go:91
+0x94
goa.design/plugins/v3/cors/examples/calc.TestMountIndexHTML(0x140000829c0)
/Users/_/go/src/goa.design/plugins/cors/examples/calc/calc_test.go:16
+0xdc
testing.tRunner(0x140000829c0, 0x104966990)
/opt/homebrew/Cellar/go/1.17.3/libexec/src/testing/testing.go:1259
+0x104
created by testing.(*T).Run
/opt/homebrew/Cellar/go/1.17.3/libexec/src/testing/testing.go:1306
+0x328
FAILgoa.design/plugins/v3/cors/examples/calc0.157s
FAIL
|
This is great and a bit of a doh! Thank you. |
|
My pleasure! Thanks for merging it so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code was making an unnecessary type assertion from
http.Handlertohttp.HandlerFuncthat was panicking when trying to use CORS for a service withFiles.This fixes the problem.
The change is split into multiple commits to hopefully help with the review.