goakit: Name services in import paths consistently with goa #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be really great if this PR could take advantage of the changes in goadesign/goa#2988, but I suspect that would require a new release over there, before this could be merged. |
|
This looks great, I am planning on releasing Goa "soon" - I'd like to fix a couple of issues that have been reported first but should be able to get to it over the coming week. |
|
Cool, so, I suppose I'll just go ahead and amend that last commit of this PR right away, and, once the new tag lands in the |
antichris
force-pushed
the
goakit-import-path-consistency
branch
from
affce1b to
d5ba27d
Compare
|
Yes sounds great |
|
Just released v3.5.5 |
That is, a name, that should be processed by `codegen.Goify()` before getting used in file system and import paths.
antichris
force-pushed
the
goakit-import-path-consistency
branch
from
d5ba27d to
d063ecb
Compare
|
This is great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116