New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom streams and paths #118

Merged
merged 18 commits into from Mar 12, 2014

Conversation

3 participants
@lisachenko
Member

lisachenko commented Jan 23, 2014

This PR introduces support for different stream wrappers, such as http://, phar://, compress.zlib://, etc. This PR is experimental now because realpath() and stream_resolve_include_path() functions were replaced with custom resolver, need to add test cases before merging into master to verify, that everything is ok.

After merging of this PR it will be possible to use goaop for standalone console applications and tools that can be very interesting.

@lisachenko

This comment has been minimized.

Show comment
Hide comment
@lisachenko

lisachenko Jan 23, 2014

Member

PR for #117

Member

lisachenko commented Jan 23, 2014

PR for #117

lisachenko added some commits Jan 23, 2014

@lisachenko

This comment has been minimized.

Show comment
Hide comment
@lisachenko

lisachenko Jan 24, 2014

Member

@cordoval you can try to play with https://github.com/lisachenko/gush/commit/64ad7d80eaf7b20f56097cb24233ae8c07b15530. It's initial configuration that simple prevent execution of gush itself :)

Member

lisachenko commented Jan 24, 2014

@cordoval you can try to play with https://github.com/lisachenko/gush/commit/64ad7d80eaf7b20f56097cb24233ae8c07b15530. It's initial configuration that simple prevent execution of gush itself :)

Simplify path resolve check for normal files, this also fixes issue w…
…ith relative including and include_path checking

@lisachenko lisachenko added Feature and removed Improvement labels Feb 11, 2014

lisachenko added some commits Mar 12, 2014

Merge branch 'master' into feature/phar-support
Conflicts:
	src/Go/Core/GoAspectContainer.php
	src/Go/Instrument/ClassLoading/SourceTransformingLoader.php
	src/Go/Instrument/Transformer/WeavingTransformer.php

lisachenko added a commit that referenced this pull request Mar 12, 2014

Merge pull request #118 from lisachenko/feature/phar-support
Add support for custom streams and paths

@lisachenko lisachenko merged commit 2ed1ec1 into master Mar 12, 2014

1 check was pending

default Scrutinizer: Running Analyses
Details

@lisachenko lisachenko deleted the feature/phar-support branch Mar 12, 2014

@matthiasnoback

This comment has been minimized.

Show comment
Hide comment
@matthiasnoback

matthiasnoback commented Mar 13, 2014

@lisachenko Interesting work!

@lisachenko

This comment has been minimized.

Show comment
Hide comment
@lisachenko

lisachenko Mar 13, 2014

Member

@matthiasnoback yes, it was very interesting to solve this outstanding task :) There was a lot of magic and it took all my knowledge about streams to implement this properly. Hope, that I didn't make an error somewhere...

Thank you for your interest to my work :)

Member

lisachenko commented Mar 13, 2014

@matthiasnoback yes, it was very interesting to solve this outstanding task :) There was a lot of magic and it took all my knowledge about streams to implement this properly. Hope, that I didn't make an error somewhere...

Thank you for your interest to my work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment