New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use with react-hot-loader
#29
Comments
It sounds like it's recreating the stores which is not a good thing. I'll take a closer look at this. If you have any code you can share please do :) |
https://github.com/iam4x/isomorphic-flux-boilerplate Edit |
Would love for this to work, this is one of the major pains with react-hot-loader and alt. It reloads the relevant changed scripts so I thought it just couldn’t be fixed easily. |
So it's a webpack bug: Let me think of ways to get around this in the meantime |
Yeah it's a Webpack bug. It's been annoying for months but I just got around to isolating it yesterday. Hopefully the fix is in the works! |
Fixed by webpack :) |
You'll need to update Webpack to 1.7.0 to get the fix. |
Hmm.. I am still receiving this error on Webpack 1.7.3, any thoughts @gaearon @goatslacker @iam4x? |
Double check you are on the latest version - ever since I upgraded to 1.7 I haven't had this issue On Wed, Mar 18, 2015 at 7:17 PM, bizmurr notifications@github.com wrote:
|
Yeah, I am on 1.7.3 and still get the error when I make some code changes to a Store and then save, is this a different issue entirely? |
The original bug is about changing the component:
If you make changes in the store, there's nothing RHL can do: it doesn't know how to handle updates in an Alt store (at least not just yet :-). It only updates components, and files which are |
Ah I see, thanks for the clarification! |
Actually let me open a new ticket. |
There was an issue with Webpack (goatslacker/alt#29) that caused stores to be reloaded even when a component is updated. I encountered this issue and it is fixed in newer webpack releases - so I decided to update it.
Using alt with
react-hot-loader
loader in webpack, throw me random errors:I couldn't find what isn't working, went through this issue: moreartyjs/todomvc-moreartyjs#2
Maybe something with the context?
The text was updated successfully, but these errors were encountered: