Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move utils out to separate repo? #98

Closed
goatslacker opened this issue Mar 27, 2015 · 4 comments
Closed

Move utils out to separate repo? #98

goatslacker opened this issue Mar 27, 2015 · 4 comments
Labels

Comments

@goatslacker
Copy link
Owner

Maybe we should move each individual util out to its own separate repo that way it can be versioned accordingly?

This may make sense for larger utils but not so much for smaller ones. I'm thinking we do the same for components.

Thoughts?

I sort of like having everything in one repo so I'm a bit hesitant, the versioning is the only pro we really gain.

@jdlehman
Copy link
Collaborator

This isnt a bad idea. I think there is something nice about everything being in one place (easier to find etc), but moving utils/components out might also help encourage more people to develop their own alt utils. Do you see alt bringing in these utils/components as dependencies that it also exports, or do you see users needing to bring these deps into their projects explicitly? It seems like it might be a bit excessive to have each util/component in its own repo, so a third option to discuss would be a components repo and a utils repo.

Another alternative would be to export these "addons" as named exports:

import alt from '../src/alt';
import manager from '../utlis/AltManager';

export default alt;
export const AltManager = manager;

usage

import alt, {AltManager}, {AnotherUtil}, {Util3} from 'alt';

@goatslacker
Copy link
Owner Author

I don't want to have them as named exports because then the code bundle size increases. Having them part of addons is ok right now. But yeah, maybe we should selectively move some utils out to separate repos?

@jdlehman
Copy link
Collaborator

That makes sense. The question is, which ones do we move out? If we only move out some will it be hard for people to find the utils they need? Obviously we would need to add a list of the official ones somewhere.

@goatslacker
Copy link
Owner Author

I think if this is premature, we can think about moving them out later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants