Cleanup generated files after each step - #210
Closed
yeganemehr wants to merge 2 commits into
Closed
Conversation
huacnlee
reviewed
Dec 12, 2023
|
|
||
| archivePath, err = encryptor.Run(archivePath, m.Config) | ||
| logger.Infof("Cleanup WorkDir: %s/", m.Config.DumpPath) | ||
| if err := os.RemoveAll(m.Config.DumpPath); err != nil { |
Collaborator
There was a problem hiding this comment.
This action looks like danger, we need to use a common method for cleanup the dump info, not call os.RemoveAll directly.
huacnlee
reviewed
Dec 12, 2023
| if err != nil { | ||
| return | ||
| } | ||
| if encryptedPath != archivePath { |
Collaborator
There was a problem hiding this comment.
This logic is hard to read, I don't like it. We need to find other way to remove the last tmp file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It's related to #208
Model's dump directory after making compressed file is no longer needed and that space can be used in next steps.
This also apply to compressed file after encryption and encrypted file after splitting.
Solution