Skip to content
Permalink
Browse files

Update CONTRIBUTING.md (#1583)

small grammar/spelling fixes
  • Loading branch information...
paulwaldmann authored and markbates committed Feb 10, 2019
1 parent 73c76b6 commit e039ba8710cea2e6cbb8a8e1c28a0ca01624cf80
Showing with 3 additions and 3 deletions.
  1. +3 −3 .github/CONTRIBUTING.md
@@ -26,20 +26,20 @@ Support for Go Modules were introduced in [Release v0.13.0-beta.1](https://githu
2. If you want to implement a new feature that doesn't have an issue open, please open one and ask for feedback on the feature before spending a lot of time working on it. It's possible the feature has already been discussed, or it's out of scope, or some other reason that might later prevent a PR from being accepted. The [#buffalo](https://gobuffalo.io/docs/slack) channel on gophers.slack.com is a great place to seek this kind of guidance.
3. Write your feature/fix and make sure to include tests. Tests are an **absolute** requirement for any pull request. Please make sure to use the same testing style and libraries as the rest of the tests.
4. Make sure tests run when doing `go test ./...`. You may need to do `go get -t ./...` first to get the testing dependencies.
5. (Optional) There is a much longer set of integration tests that can be run. These will be run by Travis-CI when you open a PR. If you want to run them locally you can by running `docker build .`.
5. (Optional) There is a much longer set of integration tests that can be run. These will be run by Travis-CI when you open a PR. If you want to run them locally, you can by running `docker build .`.

### Making your Pull Request

Open a PR against the `development` branch. **_DO NOT_** open one against `master` unless you are explicitly told to. All "unreleased" work happens in the `development` branch.

## Documentation Welcome

Hands down the most important, and the most welcome, pull requests are for documentation. We LOVE documentation PRs, and so do all those that come after you.
Hands down the most important and the most welcome pull requests are for documentation. We LOVE documentation PRs, and so do all those that come after you.

Whether it's GoDoc or prose on [http://gobuffalo.io](http://gobuffalo.io) all documentation is welcome.

You can submit PRs to change the website and/or docs on [https://github.com/gobuffalo/gobuffalo](https://github.com/gobuffalo/gobuffalo).

## Thank You

Once again, we just want to take the chance to say thank you again for wanting to contribute to Buffalo. This is a community project and that means we **need** your help! Thank you so much.
Once again, we want to take the chance to say thank you again for wanting to contribute to Buffalo. This is a community project, and that means we **need** your help! Thank you so much.

0 comments on commit e039ba8

Please sign in to comment.
You can’t perform that action at this time.