Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete buffalo.css Template (buffalo new --skip-webpack) #1662

Open
thegoose51 opened this issue May 9, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@thegoose51
Copy link

commented May 9, 2019

Description

The template used to generate public/assets/buffalo.css is missing a portion of configuration at the start of the file.

Steps to Reproduce the Problem

$ buffalo new --skip-webpack <my-app>

configure database.yml

$ buffalo db create -a
$ buffalo db migrate
$ buffalo dev

Expected Behavior

public/assets/buffalo.css should be a complete CSS file with proper attributes for the current version of buffalo. All assets should be present on http://localhost:3000 and presentable.

Actual Behavior

The file public/assets/buffalo.css is missing a portion of the configuration at the start of the file.

The index header is white on a white background; perhaps not the expected result?

.titles h1 {
  ...
  color: white; /* Should this be black? */
  ...
}

image

image

Info

λ buffalo info
-> Go: Checking installation
✓ The `go` executable was found on your system at: C:\Go\bin\go.exe

-> Go: Checking minimum version requirements
✓ Your version of Go, 1.12.4, meets the minimum requirements.

-> Go: Checking GOPATH
✓ You are using Go Modules, so no need to worry about the GOPATH.

-> Go: Checking Package Management
✓ You are using Go Modules (`go`) for package management.

-> Go: Checking PATH
✘ Your PATH (PATH NOT FOUND) does not contain%GOPATH%/bin.

Without %GOPATH%/bin in your `PATH` any Go executables can not be run globally.

For help setting up your Go environment please follow the instructions for you platform at:

https://www.gopherguides.com/courses/preparing-your-environment-for-go-development

-> Node: Checking installation
✓ The `node` executable was found on your system at: C:\Program Files\nodejs\node.exe

-> Node: Checking minimum version requirements
✓ Your version of Node, v12.2.0, meets the minimum requirements.

-> NPM: Checking installation
✓ The `npm` executable was found on your system at: C:\Program Files\nodejs\npm.cmd

-> NPM: Checking minimum version requirements
✓ Your version of NPM, 6.9.0, meets the minimum requirements.

-> Yarn: Checking installation
✓ The `yarnpkg` executable was found on your system at: C:\Program Files (x86)\Yarn\bin\yarnpkg.cmd

-> Yarn: Checking minimum version requirements
✓ Your version of Yarn, 1.13.0, meets the minimum requirements.

-> PostgreSQL: Checking installation
✘ The `postgres` executable could not be found on your system.
For help setting up your Postgres environment please follow the instructions for you platform at:

https://www.postgresql.org/download/

-> MySQL: Checking installation
✘ The `mysql` executable could not be found on your system.
For help setting up your MySQL environment please follow the instructions for you platform at:

https://www.mysql.com/downloads/

-> SQLite3: Checking installation
✘ The `sqlite3` executable could not be found on your system.
For help setting up your SQLite3 environment please follow the instructions for you platform at:

https://www.sqlite.org/download.html

-> Cockroach: Checking installation
✘ The `cockroach` executable could not be found on your system.
For help setting up your Cockroach environment please follow the instructions for you platform at:

https://www.cockroachlabs.com/docs/stable/

-> Buffalo: Checking installation
✓ The `buffalo` executable was found on your system at: %GOPATH%\bin\buffalo.exe

-> Buffalo: Checking minimum version requirements
✓ Your version of Buffalo, v0.14.3, meets the minimum requirements.

-> Buffalo: Application Details
Pwd         %GOPATH%\src\<my-app>
Root        %GOPATH%\src\<my-app>
GoPath      %GOPATH%
PackagePkg  <my-app>
ActionsPkg  <my-app>/actions
ModelsPkg   <my-app>/models
GriftsPkg   <my-app>/grifts
WithModules true
Name        <my-app>
Bin         bin\<my-app>
VCS         git
WithPop     true
WithSQLite  false
WithDep     false
WithWebpack false
WithNodeJs  true
WithYarn    true
WithDocker  true
WithGrifts  true
AsWeb       true
AsAPI       false
InApp       true
PackageJSON {map[]}

-> Buffalo: config/buffalo-app.toml
name = "<my-app>"
bin = "bin\\<my-app>"
vcs = "git"
with_pop = true
with_sqlite = false
with_dep = false
with_webpack = false
with_nodejs = true
with_yarn = true
with_docker = true
with_grifts = true
as_web = true
as_api = false

-> Buffalo: config/buffalo-plugins.toml
[[plugin]]
  binary = "buffalo-plugins"
  go_get = "github.com/gobuffalo/buffalo-plugins"

[[plugin]]
  binary = "buffalo-pop"
  go_get = "github.com/gobuffalo/buffalo-pop"

-> Buffalo: go.mod
module <my-app>

go 1.12

require (
        github.com/codegangsta/negroni v1.0.0 // indirect
        github.com/gobuffalo/buffalo v0.14.3
        github.com/gobuffalo/buffalo-pop v1.12.0
        github.com/gobuffalo/envy v1.7.0
        github.com/gobuffalo/mw-csrf v0.0.0-20190129204204-25460a055517
        github.com/gobuffalo/mw-forcessl v0.0.0-20190224202501-6d1ef7ffb276
        github.com/gobuffalo/mw-i18n v0.0.0-20190224203426-337de00e4c33
        github.com/gobuffalo/mw-paramlogger v0.0.0-20190224201358-0d45762ab655
        github.com/gobuffalo/packr v1.25.0
        github.com/gobuffalo/packr/v2 v2.2.0
        github.com/gobuffalo/pop v4.11.0+incompatible
        github.com/gobuffalo/suite v2.6.2+incompatible
        github.com/markbates/grift v1.0.5
        github.com/unrolled/secure v1.0.0
)
@thegoose51

This comment has been minimized.

Copy link
Author

commented May 9, 2019

I found that .titles h1 should not be black. White is correct.

.titles h1 {
  ...
  color: white; /* Should this be black? */
  ...
}

Adding the missing line to the top of buffalo.css corrects the issue and applies the proper blue background.

.container {

Looking (probably too closely), the .gitignore has public/assets in it. This should probably be omitted for --skip-webpack since there is not a dedicated ./assets folder.

@markbates

This comment has been minimized.

Copy link
Member

commented May 9, 2019

A PR would be great!

@thegoose51

This comment has been minimized.

Copy link
Author

commented May 9, 2019

@markbates I will get started on one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.