Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

App.Group incorrectly builds paths on Windows machines #258

Closed
schigh opened this issue Feb 21, 2017 · 5 comments
Closed

App.Group incorrectly builds paths on Windows machines #258

schigh opened this issue Feb 21, 2017 · 5 comments
Labels
os-specific This issue is OS-specific

Comments

@schigh
Copy link
Contributor

schigh commented Feb 21, 2017

When creating routing groups (e.g. /api/v1/), the Group function uses the path.Join function. This function is using the path separator provided in the OS. This is causing grouped routes to fail on Windows machines (See image below)

A POC (working on my Windows builds) implementation of a fix is here:
schigh@c61f933

ii_15a618201010feb3

edit: I should also point out that this may affect the Resource functionality as it uses the filepath namespace, but I have not tested it as it's not in my use case.

@markbates
Copy link
Member

It probably does affect the Resources stuff as well. Would you mind opening a PR for this?

@markbates
Copy link
Member

I will very happily merge it!

@schigh
Copy link
Contributor Author

schigh commented Feb 21, 2017

No prob. I will do this after a few more sanity checks on my end.

@markbates
Copy link
Member

Awesome! Thanks!

@schigh
Copy link
Contributor Author

schigh commented Feb 21, 2017

Verified paths are correct on Windows machine. PR to be sent.

screen-shot-2017-02-21-at-2 14 02-pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
os-specific This issue is OS-specific
Projects
None yet
Development

No branches or pull requests

2 participants