Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov.io badge #1100

Merged
merged 4 commits into from Jun 12, 2018

Conversation

Projects
None yet
2 participants
@AlekSi
Copy link
Contributor

AlekSi commented Jun 12, 2018

There is no coverage information for master branch yet, that's why badge says "unknown" for now.

.codecov.yml format is documented here. See also next pages; specifically, here for what "range" means.

@AlekSi

This comment has been minimized.

Copy link
Contributor Author

AlekSi commented Jun 12, 2018

btw, @markbates, you can add --squash to docker build for gobuffalo/buffalo:development image to make it significantly smaller.

@markbates

This comment has been minimized.

Copy link
Member

markbates commented Jun 12, 2018

@AlekSi if you know how to do that on hub.docker.com please let me know. That's where we build the images.

@AlekSi

This comment has been minimized.

Copy link
Contributor Author

AlekSi commented Jun 12, 2018

Looks like it is not possible: docker/hub-feedback#955 One workaround is to use multi-stage builds which are supported. Another one is to rebuild this image somewhere else.

@markbates

This comment has been minimized.

Copy link
Member

markbates commented Jun 12, 2018

@AlekSi feel free and take a crack at making it smaller.

markbates added some commits Jun 12, 2018

@markbates markbates merged commit 3c1337c into gobuffalo:development Jun 12, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@markbates markbates added this to the 0.12.0 milestone Jun 12, 2018

@AlekSi AlekSi deleted the AlekSi:codecov-badge branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.