Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes strange issues with pages being downloaded instead of rendered #1402

Merged
merged 4 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@markbates
Copy link
Member

commented Oct 23, 2018

No description provided.

@markbates markbates requested a review from gobuffalo/core-managers as a code owner Oct 23, 2018

markbates added some commits Oct 23, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Oct 23, 2018

Codecov Report

Merging #1402 into development will increase coverage by 0.04%.
The diff coverage is 72.72%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1402      +/-   ##
===============================================
+ Coverage        46.93%   46.97%   +0.04%     
===============================================
  Files               88       88              
  Lines             3927     3936       +9     
===============================================
+ Hits              1843     1849       +6     
- Misses            1996     1998       +2     
- Partials            88       89       +1
Impacted Files Coverage Δ
errors.go 74.5% <72.72%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903d1d1...33afdf6. Read the comment docs.

@markbates markbates added this to the v0.13.2 milestone Oct 23, 2018

@markbates markbates merged commit bd019c7 into development Oct 23, 2018

5 checks passed

WIP ready for review
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@markbates markbates deleted the fix-strange-error-issues branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.