Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes the -no-sqlite from the released binaries #1536

Merged
merged 2 commits into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@markbates
Copy link
Member

markbates commented Jan 15, 2019

It seems odd to name the released binaries buffalo-no-sqlite when there isn't a buffalo-with-sqlite. Also, since sqlite support is opt-in it should be buffalo without sqlite and buffalo-with-sqlite, if we ever decide to do that.

@markbates markbates requested a review from gobuffalo/core-managers as a code owner Jan 15, 2019

@markbates markbates added this to the v0.14.0 milestone Jan 15, 2019

Show resolved Hide resolved .goreleaser.yml.plush Outdated
Update .goreleaser.yml.plush
Co-Authored-By: markbates <mark@markbates.com>

@markbates markbates merged commit 7335d70 into development Jan 17, 2019

3 checks passed

code-analysis/fixmie The Fixmie analysis has finished
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@markbates markbates deleted the change-releaser-bin branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.