Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALT] Overriding app.ErrorMiddleware has no effect fixes #1466 #1564

Merged
merged 4 commits into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@markbates
Copy link
Member

markbates commented Feb 3, 2019

alternate take on #1563

@markbates markbates requested a review from gobuffalo/core-managers as a code owner Feb 3, 2019

@fixmie
Copy link

fixmie bot left a comment

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

markbates added some commits Feb 3, 2019

@markbates markbates added this to the v0.14.0 milestone Feb 3, 2019

@markbates markbates self-assigned this Feb 3, 2019

@markbates markbates merged commit a6e2fa5 into development Feb 3, 2019

3 checks passed

code-analysis/fixmie The Fixmie analysis has finished
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@markbates markbates deleted the fix-error-middleware-alt branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.