Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next #1710

Draft
wants to merge 40 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@markbates
Copy link
Member

commented Jun 23, 2019

This is just a draft PR for the next release.

The idea of this draft PR is to help people better understanding what is currently slated for the next release.

stanislas-m and others added some commits Jun 7, 2019

Decrease docker image size (#1694)
* Decrease docker image size

rm commands need to be in the same layer as that adds whatever gets cached or is unneeded. This is because docker layers are append only.

Signed-off-by: Todd Brown <todd@proceedfinance.com>

* Add mkdir back in to dockerfile

Signed-off-by: Todd Brown <todd@proceedfinance.com>
修改 fa fa-github 为 fab fa-github (#1692)
由于 fa-github 图标 并不在 fa class 下 而在 fab class下
导致 fa-github 图标得不到显示 所以修改为 fab
removes the direct dependency on gobuffalo/x (#1708)
* removes the direct dependency on gobuffalo/x

* remove the older *gen packages
pulls in the buffalo-docker plugin (#1709)
* pulls in the buffalo-docker plugin

* remove syncx
Add more contributing guidelines (#1715)
Make sure the rules are clear, and precise we will close non-compliant
contributions. Also please don't @ markbates. :D
Replace hard-coded webpack with node script call (#1718)
* Replace hard-coded webpack with node script call

* Fix assets test

* Fix some issues with the fix command

* Rewrite package.json only if necessary

* Fix WithNodeJs opt

Currently, the only way to generate a project with node is to use
Webpack. If the --skip-webpack flag is used, WithNodeJs must be false
then.
Use model#isPlural to pick which template to auto-render (#1728)
* Use plural vs. singular to pick which template to auto render,

This allows using dashes instead of underscores in resource urls.

* add test cases

@markbates markbates added this to the Next milestone Jul 10, 2019

markbates and others added some commits Jul 10, 2019

catches uncaught build error; fixes issues with buffalo build if the …
…package.json doesn't contain the build scripts (#1729)
Fix uuid and nulls packages in buffalo fix (#1732)
github.com/gobuffalo/uuid => github.com/gofrs/uuid
github.com/gobuffalo/pop/nulls => github.com/gobuffalo/nulls
Add ARM builds for buffalo (#1733)
Configure Goreleaser to build for Linux ARM targets.

Fixes #1713.
Add scheme to server address (#1734)
This makes it easier to CMD + click the URL when the server is started.
Fix assets are not extracted (#1736)
Final zip was deleted by Cleanup routine, and the generated zip
was not valid.

Fixes #1717
Avoid poisoning plugin cache (#1737)
* plugins: move addToCache to avoid bad entries

This came from an issue referenced on slack (gophers #buffalo on 2019-07-12) where I could not get buffalo plugins, especially pop, to load properly.

It happened because my machine timed out trying to run `buffalo-pop available`, and it cached a bad entry with no commands.

It seems like we should only cache the commands if we got a successful response from the given binary.

The downside here is that if there is a `buffalo-<something>` binary and we're failing to get commands from it, buffalo will try again on it every time. I've added logging for that error so it's clear to the user why buffalo is loading slowly and so they can fix the issue.

* Updated plugins test
@fixmie
Copy link

left a comment

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

"github.com/gobuffalo/buffalo/internal/defaults"
)

func ContentType(req *http.Request) string {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

exported identifier "ContentType" should have comment

Suggested change
func ContentType(req *http.Request) string {
// ContentType ...
func ContentType(req *http.Request) string {
"github.com/gobuffalo/meta"
)

type Options struct {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

exported identifier "Options" should have comment

Suggested change
type Options struct {
// Options ...
type Options struct {
"github.com/gobuffalo/packr/v2"
)

func New(opts *Options) (*genny.Generator, error) {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

exported identifier "New" should have comment

Suggested change
func New(opts *Options) (*genny.Generator, error) {
// New ...
func New(opts *Options) (*genny.Generator, error) {

// LoadOrStore will return an existing key or
// store the value if not already in the map
func (m *stringMap) LoadOrStore(key string, value string) (string, bool) {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

two or more consecutive named function parameters share a type, you can omit the type from all but the last

Suggested change
func (m *stringMap) LoadOrStore(key string, value string) (string, bool) {
func (m *stringMap) LoadOrStore(key, value string) (string, bool) {
}

// Store a string in the map
func (m *stringMap) Store(key string, value string) {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

two or more consecutive named function parameters share a type, you can omit the type from all but the last

Suggested change
func (m *stringMap) Store(key string, value string) {
func (m *stringMap) Store(key, value string) {

var Cause = Unwrap

func Wrap(err error, msg string) error {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

exported identifier "Wrap" should have comment

Suggested change
func Wrap(err error, msg string) error {
// Wrap ...
func Wrap(err error, msg string) error {
return s1
}

func Int(i1, i2 int) int {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

exported identifier "Int" should have comment

Suggested change
func Int(i1, i2 int) int {
// Int ...
func Int(i1, i2 int) int {
return i1
}

func Int64(i1, i2 int64) int64 {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

exported identifier "Int64" should have comment

Suggested change
func Int64(i1, i2 int64) int64 {
// Int64 ...
func Int64(i1, i2 int64) int64 {
return i1
}

func Float32(i1, i2 float32) float32 {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

exported identifier "Float32" should have comment

Suggested change
func Float32(i1, i2 float32) float32 {
// Float32 ...
func Float32(i1, i2 float32) float32 {
return i1
}

func Float64(i1, i2 float64) float64 {

This comment has been minimized.

Copy link
@fixmie

fixmie bot Jul 17, 2019

exported identifier "Float64" should have comment

Suggested change
func Float64(i1, i2 float64) float64 {
// Float64 ...
func Float64(i1, i2 float64) float64 {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.