Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catches uncaught build error; fixes issues with buffalo build if the package.json doesn't contain the build scripts #1729

Merged
merged 4 commits into from Jul 12, 2019

Conversation

Projects
None yet
2 participants
@markbates
Copy link
Member

commented Jul 10, 2019

No description provided.

markbates added some commits Jul 10, 2019

catches uncaught build error; fixes issues with buffalo build if the
package.json doesn't contain the build scripts

@markbates markbates requested a review from gobuffalo/core-managers as a code owner Jul 10, 2019

@markbates markbates requested a review from stanislas-m Jul 10, 2019

@markbates markbates added this to the Next milestone Jul 10, 2019

@stanislas-m
Copy link
Member

left a comment

https://github.com/gobuffalo/oldapp/tree/master/0_13_6 seems to have a module issue on update, but this is not related to this fix.

@markbates markbates merged commit 3cea810 into development Jul 12, 2019

15 of 18 checks passed

gobuffalo.buffalo Build #20190712.2 failed
Details
gobuffalo.buffalo (macOS go 1.12 (off))
Details
Fixmie The Fixmie analysis has started
gobuffalo.buffalo (IntegrationTests) IntegrationTests succeeded
Details
gobuffalo.buffalo (Linux go 1.10) Linux go 1.10 succeeded
Details
gobuffalo.buffalo (Linux go 1.11 (off)) Linux go 1.11 (off) succeeded
Details
gobuffalo.buffalo (Linux go 1.11 (on)) Linux go 1.11 (on) succeeded
Details
gobuffalo.buffalo (Linux go 1.12 (off)) Linux go 1.12 (off) succeeded
Details
gobuffalo.buffalo (Linux go 1.12 (on)) Linux go 1.12 (on) succeeded
Details
gobuffalo.buffalo (Windows go 1.10) Windows go 1.10 succeeded
Details
gobuffalo.buffalo (Windows go 1.11 (off)) Windows go 1.11 (off) succeeded
Details
gobuffalo.buffalo (Windows go 1.11 (on)) Windows go 1.11 (on) succeeded
Details
gobuffalo.buffalo (Windows go 1.12 (off)) Windows go 1.12 (off) succeeded
Details
gobuffalo.buffalo (Windows go 1.12 (on)) Windows go 1.12 (on) succeeded
Details
gobuffalo.buffalo (macOS go 1.10) macOS go 1.10 succeeded
Details
gobuffalo.buffalo (macOS go 1.11 (off)) macOS go 1.11 (off) succeeded
Details
gobuffalo.buffalo (macOS go 1.11 (on)) macOS go 1.11 (on) succeeded
Details
gobuffalo.buffalo (macOS go 1.12 (on)) macOS go 1.12 (on) succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.