Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append URL and Query String parameter dupplicates #1778

Open
wants to merge 1 commit into
base: master
from

Conversation

@Max-Pol
Copy link

commented Aug 29, 2019

Fix to issue #1777

A quick fix to be able to manage duplicates in URL Params and query string params.

Example :

route: GET /users/{user_id}

call: GET /users/001?user_id=002&user_id=003

Previous Behavior

c.Params():

{
    "user_id": [
        "003"
    ]
}

c.Param("user_id"): "003"

New Behavior

c.Params():

{
    "user_id": [
        "001",
        "002",
        "003",
    ]
}

c.Param("user_id"): "001"

@Max-Pol Max-Pol requested a review from gobuffalo/core-managers as a code owner Aug 29, 2019

@markbates
Copy link
Member

left a comment

Can you please add tests for this? Thanks.

@Max-Pol Max-Pol force-pushed the Max-Pol:master branch 2 times, most recently from 4bb9c2c to 6ce6c60 Aug 29, 2019

@Max-Pol

This comment has been minimized.

Copy link
Author

commented Aug 29, 2019

Can you please add tests for this? Thanks

I added tests, sorry I should have done it before...

Thanks for this awesome project btw :)

@Max-Pol Max-Pol force-pushed the Max-Pol:master branch from 6ce6c60 to 6c9cbad Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.