Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not the plural. #1783

Closed
wants to merge 4 commits into from

Conversation

stanislas-m and others added 4 commits Aug 13, 2019

@leo-baltus leo-baltus requested a review from gobuffalo/core-managers as a code owner Sep 3, 2019

@mclark4386
Copy link
Member

left a comment

Please PR against development

@leo-baltus leo-baltus changed the base branch from master to development Sep 4, 2019

@leo-baltus

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

Anything I can do?

@paganotoni

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@leo-baltus It seems there is still a conflict with development. I suggest you create a new branch from development and apply the change there, then send a PR from that branch into development.

@leo-baltus

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

sorry, thats just too many hoops to jump through. It's just a typo, you get the idea.

@paganotoni

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Alright. Are you ok if I send another PR with this change?

@paganotoni

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@leo-baltus I created #1786. Closing this one.

@paganotoni paganotoni closed this Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.