Task: Year change in the footer copyright. #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gobuffalo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sio4
requested changes
Mar 3, 2023
Member
sio4
left a comment
sio4
left a comment
There was a problem hiding this comment.
Could you please take a look at my comment?
Contributor
Author
|
sio4
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
This PR changes the static year in the footer to the current year.
What are the main choices made to get to this solution?
basically use the current year and separate the rest of the copyright text in the different languages and directly add the copyright by concatenating the rest of the copyright text.
List the manual test cases you've covered before sending this PR:
Given the copyright, change click on the language options verifying that the year is the current one.
Given the copyright has been changed it should work for all languages.
Given the copyright has been changed it should appear the same words previous to the change.