Skip to content
This repository has been archived by the owner on Jun 25, 2022. It is now read-only.

Publish binaries for releases #25

Closed
metalmatze opened this issue Dec 5, 2017 · 9 comments
Closed

Publish binaries for releases #25

metalmatze opened this issue Dec 5, 2017 · 9 comments

Comments

@metalmatze
Copy link
Contributor

Hey!
I really enjoy packr and use it on over 10+ projects now. During my CI/CD I sometimes need to go get packr, which is rather annoying because it takes a minute. It would be super dope, if you could provide some pre-build binaries (linux-amd64 for me). That way I could just curl them in my CI/CD and that's it.
Thanks!

@markbates
Copy link
Member

That would be great. A PR would be awesome.

@metalmatze
Copy link
Contributor Author

How would I do a PR so you can upload the binaries? Are you talking about Travis? 🤔

@markbates
Copy link
Member

markbates commented Dec 6, 2017 via email

@metalmatze
Copy link
Contributor Author

Yep. I do that with drone a lot. I'll just have to take a look on how to do it with Travis when tagging. 😎

@markbates
Copy link
Member

You are awesome!

@markbates
Copy link
Member

The command "GOARCH=amd64 GOOS=darwin go build -v -o packr_darwin_amd64 ./packr" exited with 0.
Skipping a deployment with the releases provider because a custom condition was not met

@metalmatze
Copy link
Contributor Author

Yes. The condition is, that it is only run iff a release was tagged with git tag

@markbates
Copy link
Member

Not working. :(

https://travis-ci.org/gobuffalo/packr/jobs/312706654

I tagged that on using git tag v1.9.3 and then did git push origin --tags. Travis picked it up, built them, but didn't deploy them. Thoughts?

@metalmatze
Copy link
Contributor Author

It might be this line which prevents the build from running that step.
But we need that due to the matrix of running the builds with different Go versions. We only want to push the binaries built with Go 1.9.

condition: $TRAVIS_GO_VERSION =~ ^1\.9\.[0-9]+$

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants