Skip to content
This repository has been archived by the owner on Jun 25, 2022. It is now read-only.

Source tree and go module versioning #294

Closed
sio4 opened this issue Oct 30, 2021 · 4 comments · Fixed by #295
Closed

Source tree and go module versioning #294

sio4 opened this issue Oct 30, 2021 · 4 comments · Fixed by #295

Comments

@sio4
Copy link
Member

sio4 commented Oct 30, 2021

It seems like v1.30.1 which was released on 25 Jun 2019 is the last v1 version of packr. If we don't update or fix version 1 nowadays, or even though we do it, I don't think we need to keep version 1 on the root directory and hold version 2 in a separated subdirectory in parallel. Can we create v1 branch and clean up master for v2 only? (on the root)

What do you think @paganotoni @stanislas-m?

@sio4
Copy link
Member Author

sio4 commented Oct 30, 2021

I am testing this. https://github.com/gochigo/packr/tree/version2-only.

@sio4
Copy link
Member Author

sio4 commented Oct 31, 2021

Could you please create a new branch v1? Then I will make a PR from https://github.com/gochigo/packr/tree/v1 and then will make an another PR from https://github.com/gochigo/packr/tree/version2-only against master so we can separate those two versions and mainly maintain v2 in the master while we keep using packr on buffalo and other projects.

@paganotoni
Copy link
Member

Hey @sio4 thanks for putting this one together. I don't feel like I have the knowledge of Packr to vote on the proposal, I would let @stanislas-m weigh in. I truly appreciate the effort you're putting on this.

@sio4
Copy link
Member Author

sio4 commented Nov 11, 2021

Sure! thank you @paganotoni for checking the proposal anyway.

Hi @stanislas-m, sorry for a series of review requests. I hope we can modernize all the dependencies and structures so we can make buffalo easier to maintain.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants