New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build tags to generated packr files #155

Merged
merged 3 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@techknowlogick
Copy link
Contributor

techknowlogick commented Feb 5, 2019

Closes #153

@markbates

This comment has been minimized.

Copy link
Member

markbates commented Feb 6, 2019

Currently travis is having problems with Go builds, so once that's cleared up and the tests pass, I'll merge this in. Thanks.

@markbates

This comment has been minimized.

Copy link
Member

markbates commented Feb 6, 2019

@techknowlogick it looks like you can't use - in a build tag:

packrd/packed-packr.go:1: invalid non-alphanumeric build constraint: !skip-packr
Show resolved Hide resolved v2/jam/store/disk_tmpl.go Outdated
Show resolved Hide resolved v2/jam/store/disk_tmpl.go Outdated

markbates and others added some commits Feb 6, 2019

Update v2/jam/store/disk_tmpl.go
Co-Authored-By: techknowlogick <matti@mdranta.net>
Update v2/jam/store/disk_tmpl.go
Co-Authored-By: techknowlogick <matti@mdranta.net>

@markbates markbates merged commit 275b0e5 into gobuffalo:master Feb 6, 2019

2 checks passed

code-analysis/fixmie The Fixmie analysis has finished
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@markbates

This comment has been minimized.

Copy link
Member

markbates commented Feb 6, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment