Minor improvements (#236)

* use sql instead of sqlx when possible.
* disable metalinter download for now.
* harmonize the way dialects are registered.

.travis.yml

@@ -14,15 +14,15 @@ install:
   - go get -t -v ./...
 
 before_script:
-  - go get -u github.com/alecthomas/gometalinter
-  - gometalinter --install
+#  - go get -u github.com/alecthomas/gometalinter
+#  - gometalinter --install
   - go build -v -tags sqlite -o tsoda ./soda
   - ./tsoda create -e $SODA_DIALECT
   - ./tsoda migrate -e $SODA_DIALECT
 
 script:
 #  - gometalinter --vendor --deadline=5m ./...
-  - go test -tags sqlite ./... -v
+  - go test -tags sqlite ./... -v -race
 
 global_env:
   - MYSQL_USER="travis"

dialect_cockroach.go

@@ -1,6 +1,7 @@
 package pop
 
 import (
+	"database/sql"
 	"fmt"
 	"io"
 	"os"
@@ -21,6 +22,10 @@ import (
 	"github.com/pkg/errors"
 )
 
+func init() {
+	AvailableDialects = append(AvailableDialects, "cockroach")
+}
+
 var _ dialect = &cockroach{}
 
 type cockroach struct {
@@ -84,7 +89,7 @@ func (p *cockroach) SelectMany(s store, models *Model, query Query) error {
 func (p *cockroach) CreateDB() error {
 	// createdb -h db -p 5432 -U cockroach enterprise_development
 	deets := p.ConnectionDetails
-	db, err := sqlx.Open(deets.Dialect, p.urlWithoutDb())
+	db, err := sql.Open(deets.Dialect, p.urlWithoutDb())
 	if err != nil {
 		return errors.Wrapf(err, "error creating Cockroach database %s", deets.Database)
 	}
@@ -103,7 +108,7 @@ func (p *cockroach) CreateDB() error {
 
 func (p *cockroach) DropDB() error {
 	deets := p.ConnectionDetails
-	db, err := sqlx.Open(deets.Dialect, p.urlWithoutDb())
+	db, err := sql.Open(deets.Dialect, p.urlWithoutDb())
 	if err != nil {
 		return errors.Wrapf(err, "error dropping Cockroach database %s", deets.Database)
 	}

dialect_mysql.go

@@ -2,6 +2,7 @@ package pop
 
 import (
 	"bytes"
+	"database/sql"
 	"fmt"
 	"io"
 	"os"
@@ -14,11 +15,14 @@ import (
 	"github.com/gobuffalo/fizz/translators"
 	"github.com/gobuffalo/pop/columns"
 	"github.com/gobuffalo/pop/logging"
-	"github.com/jmoiron/sqlx"
 	"github.com/markbates/going/defaults"
 	"github.com/pkg/errors"
 )
 
+func init() {
+	AvailableDialects = append(AvailableDialects, "mysql")
+}
+
 var _ dialect = &mysql{}
 
 type mysql struct {
@@ -82,7 +86,7 @@ func (m *mysql) SelectMany(s store, models *Model, query Query) error {
 // CreateDB creates a new database, from the given connection credentials
 func (m *mysql) CreateDB() error {
 	deets := m.ConnectionDetails
-	db, err := sqlx.Open(deets.Dialect, m.urlWithoutDb())
+	db, err := sql.Open(deets.Dialect, m.urlWithoutDb())
 	if err != nil {
 		return errors.Wrapf(err, "error creating MySQL database %s", deets.Database)
 	}
@@ -103,7 +107,7 @@ func (m *mysql) CreateDB() error {
 // DropDB drops an existing database, from the given connection credentials
 func (m *mysql) DropDB() error {
 	deets := m.ConnectionDetails
-	db, err := sqlx.Open(deets.Dialect, m.urlWithoutDb())
+	db, err := sql.Open(deets.Dialect, m.urlWithoutDb())
 	if err != nil {
 		return errors.Wrapf(err, "error dropping MySQL database %s", deets.Database)
 	}

dialect_postgresql.go

@@ -1,6 +1,7 @@
 package pop
 
 import (
+	"database/sql"
 	"fmt"
 	"io"
 	"os"
@@ -18,6 +19,10 @@ import (
 	"github.com/pkg/errors"
 )
 
+func init() {
+	AvailableDialects = append(AvailableDialects, "postgres")
+}
+
 var _ dialect = &postgresql{}
 
 type postgresql struct {
@@ -81,7 +86,7 @@ func (p *postgresql) SelectMany(s store, models *Model, query Query) error {
 func (p *postgresql) CreateDB() error {
 	// createdb -h db -p 5432 -U postgres enterprise_development
 	deets := p.ConnectionDetails
-	db, err := sqlx.Open(deets.Dialect, p.urlWithoutDb())
+	db, err := sql.Open(deets.Dialect, p.urlWithoutDb())
 	if err != nil {
 		return errors.Wrapf(err, "error creating PostgreSQL database %s", deets.Database)
 	}
@@ -100,7 +105,7 @@ func (p *postgresql) CreateDB() error {
 
 func (p *postgresql) DropDB() error {
 	deets := p.ConnectionDetails
-	db, err := sqlx.Open(deets.Dialect, p.urlWithoutDb())
+	db, err := sql.Open(deets.Dialect, p.urlWithoutDb())
 	if err != nil {
 		return errors.Wrapf(err, "error dropping PostgreSQL database %s", deets.Database)
 	}

pop.go

@@ -1,7 +1,7 @@
 package pop
 
 // AvailableDialects lists the available database dialects
-var AvailableDialects = []string{"postgres", "mysql", "cockroach"}
+var AvailableDialects = []string{}
 
 // DialectSupported checks support for the given database dialect
 func DialectSupported(d string) bool {

test.sh

@@ -25,7 +25,7 @@ function test {
   ./tsoda drop -e $SODA_DIALECT -c ./database.yml
   ./tsoda create -e $SODA_DIALECT -c ./database.yml
   ./tsoda migrate -e $SODA_DIALECT -c ./database.yml
-  go test -tags sqlite $verbose $(go list ./... | grep -v /vendor/)
+  go test -race -tags sqlite $verbose $(go list ./... | grep -v /vendor/)
 }
 
 test "postgres"