Add contributing guidelines #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It provides some basic information, but mostly links to the main repo's guidelines to reduce duplication and make maintaining the guidelines easier.
mclark4386
approved these changes
Aug 28, 2018
| @@ -0,0 +1,7 @@ | |||
| # Contributing to POP | |||
|
|
|||
There was a problem hiding this comment.
"Pop" or "pop" -- not sure why all caps here...
There was a problem hiding this comment.
Right, I looked at the readme for that and must have stopped reading after the headline.
mclark4386
pushed a commit
that referenced
this pull request
Sep 28, 2018
It provides some basic information, but mostly links to the main repo's guidelines to reduce duplication and make maintaining the guidelines easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It provides some basic information, but mostly links to the main repo's guidelines to reduce duplication and make maintaining the guidelines easier.
I opened my first PR against master instead of development because I did not consider looking for contribution guidelines in the main repo. This should help future first-time contributors to get it right the first time and me to remember to check the base branch before opening a PR.