Improve model attributes validation #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislas-m
force-pushed
the
task/refactor-new-attribute-validation
branch
3 times, most recently
from
15a609c
to
3c5c42a
Compare
* Extract duplicates validation from Model cmd * Validate the attribute name is a valid Go name
stanislas-m
force-pushed
the
task/refactor-new-attribute-validation
branch
from
3c5c42a
to
268a9e2
Compare
mclark4386
approved these changes
Sep 4, 2018
mclark4386
pushed a commit
that referenced
this pull request
Sep 28, 2018
* Improve model attributes validation * Extract duplicates validation from Model cmd * Validate the attribute name is a valid Go name * Fix test issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to gobuffalo/buffalo#870