diff --git a/Makefile b/Makefile index 7a10530b..5bbfc4c9 100644 --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ cover-html: cover .PHONY: lint lint: golangci-lint - golangci-lint run + $(BIN_DIR)/golangci-lint run golangci-lint: | $(BIN_DIR) @{ \ diff --git a/internal/decoder/interface.go b/internal/decoder/interface.go index 19cc42a4..45c69ab8 100644 --- a/internal/decoder/interface.go +++ b/internal/decoder/interface.go @@ -458,7 +458,7 @@ func (d *interfaceDecoder) decodeEmptyInterface(ctx *RuntimeContext, cursor, dep return cursor, errors.ErrInvalidBeginningOfValue(buf[cursor], cursor) } -func NewPathDecoder() *interfaceDecoder { +func NewPathDecoder() Decoder { ifaceDecoder := &interfaceDecoder{ typ: emptyInterfaceType, structName: "", diff --git a/internal/decoder/path.go b/internal/decoder/path.go index 005e6458..71556cfc 100644 --- a/internal/decoder/path.go +++ b/internal/decoder/path.go @@ -345,10 +345,6 @@ type BasePathNode struct { child PathNode } -func (n *BasePathNode) allRead() bool { - return true -} - func (n *BasePathNode) chain(node PathNode) PathNode { n.child = node return node @@ -611,7 +607,7 @@ func (n *PathRecursiveNode) Get(src, dst reflect.Value) error { } } } - AssignValue(reflect.ValueOf(arr), dst) + _ = AssignValue(reflect.ValueOf(arr), dst) return nil case reflect.Struct: typ := src.Type() @@ -635,7 +631,7 @@ func (n *PathRecursiveNode) Get(src, dst reflect.Value) error { } } } - AssignValue(reflect.ValueOf(arr), dst) + _ = AssignValue(reflect.ValueOf(arr), dst) return nil case reflect.Array, reflect.Slice: for i := 0; i < src.Len(); i++ { @@ -646,7 +642,7 @@ func (n *PathRecursiveNode) Get(src, dst reflect.Value) error { arr = append(arr, valueToSliceValue(v)...) } } - AssignValue(reflect.ValueOf(arr), dst) + _ = AssignValue(reflect.ValueOf(arr), dst) return nil case reflect.Ptr: return n.Get(src.Elem(), dst)