Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBreak down and simplify the installation instructions #134
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ketan
Jun 25, 2015
Contributor
The documentation is temporarily available at http://ketanpkr.in/go.cd-documentation/user/current/ for review
|
The documentation is temporarily available at http://ketanpkr.in/go.cd-documentation/user/current/ for review |
arvindsv
reviewed
Jun 25, 2015
| ```bash | ||
| $ echo "deb http://dl.bintray.com/gocd/gocd-deb/ /" > /etc/apt/sources.list.d/gocd.list | ||
| $ wget --quiet -O - "https://bintray.com/user/downloadSubjectPublicKey?username=gocd" | sudo apt-key add - |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ketan
Jun 26, 2015
Contributor
Key signing is currently half-arsed. Until we sort the key signing, I'm a bit hesitant to put these in.
I don't mind putting them in after we sort the key-signing business.
ketan
Jun 26, 2015
Contributor
Key signing is currently half-arsed. Until we sort the key signing, I'm a bit hesitant to put these in.
I don't mind putting them in after we sort the key-signing business.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arvindsv
Jun 26, 2015
Member
Even after it is sorted out (I assume you mean S3, etc), the key should be the same.
arvindsv
Jun 26, 2015
Member
Even after it is sorted out (I assume you mean S3, etc), the key should be the same.
arvindsv
reviewed
Jun 25, 2015
| 1. Open ```/etc/default/go-agent``` in your favourite text editor. | ||
| 2. Change the line ```GO_SERVER=127.0.0.1``` to the hostname (or IP address) of your Go server. | ||
| 3. Save the file and exit your editor. | ||
| 4. Run ```/etc/init.d/go-agent [start|restart]``` to (re)start the agent. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arvindsv
Jun 25, 2015
Member
Like you mentioned about overrides.env for Mac OS X, can you mention that the /etc/default/go-agent file is sourced at startup and can be used to set environment variables for the agent?
arvindsv
Jun 25, 2015
Member
Like you mentioned about overrides.env for Mac OS X, can you mention that the /etc/default/go-agent file is sourced at startup and can be used to set environment variables for the agent?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arvindsv
reviewed
Jun 26, 2015
| ```bash | ||
| /Applications/Go Agent.app # The go agent application | ||
| ~/Library/Preferences/com.thoughtworks.studios.cruise.agent.properties # The agent properties |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arvindsv
Jun 26, 2015
Member
Can you also mention somewhere in this page that this file has the information about the Go Server that this agent connects to? I think it should be moved out of there, to ~/Library/Application Support/Go Agent, but for now it is the properties file.
arvindsv
Jun 26, 2015
Member
Can you also mention somewhere in this page that this file has the information about the Go Server that this agent connects to? I think it should be moved out of there, to ~/Library/Application Support/Go Agent, but for now it is the properties file.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ketan
Jun 26, 2015
Contributor
Can you also mention somewhere in this page that this file has the information about the Go Server that this agent connects to? I think it should be moved out of there, to
~/Library/Application Support/Go Agent, but for now it is the properties file.
I don't see why users need to know that, esp because they can just edit the configuration from the preferences pane.
Is there something I'm missing?
ketan
Jun 26, 2015
Contributor
Can you also mention somewhere in this page that this file has the information about the Go Server that this agent connects to? I think it should be moved out of there, to
~/Library/Application Support/Go Agent, but for now it is the properties file.
I don't see why users need to know that, esp because they can just edit the configuration from the preferences pane.
Is there something I'm missing?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arvindsv
Jun 26, 2015
Member
Someone recently asked about it. That's why I remembered. But, I don't mind if the preferences pane is mentioned, instead of that file.
I think, what causes confusion sometimes is that the Mac Go Agent is the only one having a menu bar. So, it's not always obvious where to change this setting.
arvindsv
Jun 26, 2015
Member
Someone recently asked about it. That's why I remembered. But, I don't mind if the preferences pane is mentioned, instead of that file.
I think, what causes confusion sometimes is that the Mac Go Agent is the only one having a menu bar. So, it's not always obvious where to change this setting.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arvindsv
Jun 26, 2015
Member
Apart from the notes, I really like the new format. We should link from go.cd/download to here.
|
Apart from the notes, I really like the new format. We should link from go.cd/download to here. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ketan
Jun 26, 2015
Contributor
Apart from the notes, I really like the new format. We should link from go.cd/download to here.
That would be the next thing to do.
That would be the next thing to do. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I'm ready to accept this, unless you're making any other changes. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ketan
Jun 26, 2015
Contributor
I'm ready to accept this, unless you're making any other changes.
I'm done with this PR.
I'm done with this PR. |
added a commit
that referenced
this pull request
Jun 26, 2015
ketan commentedJun 25, 2015
No description provided.