Skip to content
Permalink
Browse files Browse the repository at this point in the history
#000 - Allow parameters to be used as URLs
Relates to commit 6fa9fb7
  • Loading branch information
arvindsv committed Oct 23, 2021
1 parent 5a0da28 commit 2b77b53
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 1 deletion.
Expand Up @@ -28,7 +28,7 @@

@ConfigAttributeValue(fieldName = "url")
public class UrlArgument extends CommandArgument {
private static final String URL_DUMB_VALIDATION_REGEX = "^[a-zA-Z0-9/].*";
private static final String URL_DUMB_VALIDATION_REGEX = "^[a-zA-Z0-9/#].*";
private static final Pattern pattern = Pattern.compile(URL_DUMB_VALIDATION_REGEX);

protected String url;
Expand Down
Expand Up @@ -275,6 +275,7 @@ void rejectsObviouslyWrongURL() {
assertTrue(validating(git("@url-not-starting-with-an-alphanumeric-character")).errors().containsKey(GitMaterialConfig.URL));

assertFalse(validating(git("url-starting-with-an-alphanumeric-character")).errors().containsKey(GitMaterialConfig.URL));
assertFalse(validating(git("#{url}")).errors().containsKey(GitMaterialConfig.URL));
}

private GitMaterialConfig validating(GitMaterialConfig git) {
Expand Down
Expand Up @@ -300,6 +300,7 @@ void rejectsObviouslyWrongURL() {
assertTrue(validating(hg("@url-not-starting-with-an-alphanumeric-character", "folder")).errors().containsKey(HgMaterialConfig.URL));

assertFalse(validating(hg("url-starting-with-an-alphanumeric-character", "folder")).errors().containsKey(HgMaterialConfig.URL));
assertFalse(validating(hg("#{url}", "folder")).errors().containsKey(HgMaterialConfig.URL));
}

private HgMaterialConfig validating(HgMaterialConfig hg) {
Expand Down
Expand Up @@ -168,6 +168,7 @@ void rejectsObviouslyWrongURL() {
assertTrue(validating(svn("@url-not-starting-with-an-alphanumeric-character", false)).errors().containsKey(SvnMaterialConfig.URL));

assertFalse(validating(svn("url-starting-with-an-alphanumeric-character", false)).errors().containsKey(SvnMaterialConfig.URL));
assertFalse(validating(svn("#{url}", false)).errors().containsKey(SvnMaterialConfig.URL));
}

private SvnMaterialConfig validating(SvnMaterialConfig svn) {
Expand Down
Expand Up @@ -176,6 +176,7 @@ void rejectsObviouslyWrongURL() {
assertTrue(validating(tfs("@url-not-starting-with-an-alphanumeric-character")).errors().containsKey(TfsMaterialConfig.URL));

assertFalse(validating(tfs("url-starting-with-an-alphanumeric-character")).errors().containsKey(TfsMaterialConfig.URL));
assertFalse(validating(tfs("#{url}")).errors().containsKey(TfsMaterialConfig.URL));
}

private TfsMaterialConfig validating(TfsMaterialConfig tfs) {
Expand Down

0 comments on commit 2b77b53

Please sign in to comment.